fix: Aligns debug_traceTransaction validation with industry standards #3789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Test Results 21 files + 1 278 suites +22 19m 57s ⏱️ + 1m 47s For more details on these failures, see this check. Results for commit 2d107c6. ± Comparison against base commit d4229d9. ♻️ This comment has been updated with latest results. |
|
Hey @konstantinabl, left a comment in the respective issue #3739 (comment). |
simzzz
approved these changes
Jun 5, 2025
quiet-node
reviewed
Jun 5, 2025
konstantinabl
changed the title
quiet-node
reviewed
Jun 9, 2025
|
We need to update our Moreover, we have changed the signature of the method in a non-compatible way, meaning, should we mark this as a breaking change? Because we would need to include this in the release notes for the next release. |
acuarica
reviewed
Jun 11, 2025
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
konstantinabl
force-pushed
the
3739-need-investigation-incorrect-param-validation-for-debug_tracetransaction
branch
from
edd3ef5 to
285645f
Compare
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
…dation-for-debug_tracetransaction
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
quiet-node
requested changes
Jun 16, 2025
acuarica
reviewed
Jun 16, 2025
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
…dation-for-debug_tracetransaction
acuarica
approved these changes
Jun 20, 2025
acuarica
deleted the
3739-need-investigation-incorrect-param-validation-for-debug_tracetransaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes validation for debug_traceTransaction to align with industry standards (Alchemy, QuickNode)
Related issue(s):
Fixes #3739